semver_checks: Edit comment instead of posting new one #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Up until now semver_checks CI posted a new comment after each push to a PR if such push resulted in PR (still) having breaking changes. This was quite spammy for PRs that intentionally made breaking changes, because each and every push resulted in a new comment. This commit changes the CI so that it edits already posted comment, and only posts a new one when there was none before. If there are multiple comments already (as is the case with already open PRs) then the oldest one will be chosen for edit. The aim is to always have semver status immediately below PR description.
Lorak-mmk
force-pushed
the
semver-checks-edit-comment
branch
from
a88bf6a to
a875d12
Compare
piodul
approved these changes
Mar 10, 2024
Lorak-mmk
force-pushed
the
semver-checks-edit-comment
branch
2 times, most recently
from
5964539 to
a875d12
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up until now semver_checks CI posted a new comment after each push to a PR if such push resulted in PR (still) having breaking changes.
This was quite spammy for PRs that intentionally made breaking changes, because each and every push resulted in a new comment.
This commit changes the CI so that it edits already posted comment, and only posts a new one when there was none before.
If there are multiple comments already (as is the case with already open PRs) then the oldest one will be chosen for edit.
The aim is to always have semver status immediately below PR description.
Fixes: #938
Pre-review checklist
./docs/source/.Fixes:annotations to PR description.