Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regex for empty string |$^ in dashboards #2192

Closed
Rikkuru opened this issue Feb 29, 2024 · 1 comment · Fixed by #2207
Closed

Regex for empty string |$^ in dashboards #2192

Rikkuru opened this issue Feb 29, 2024 · 1 comment · Fixed by #2207
Labels
breaking-changes This change is not backward compatible

Comments

@Rikkuru
Copy link

Rikkuru commented Feb 29, 2024

Installation details
Panel Name: node variable and other
Dashboard Name:os-metrics and other
Scylla-Monitoring Version: master (4.6.1)
Scylla-Version: 5.0.13

Many regex in templates use this expr |$^
For example node variable in os metrics
label_values(node_filesystem_avail_bytes{cluster=~"$cluster|$^", data_center=~"$data_center"}, instance)

so we filter all nodes with selected cluster but also all nodes with missing cluster for some reason

It makes it harder to alter dashboards if your datasource is not exclusively used for scylla metrics and there are nodes without cluster label from other deployments.

Maybe this suffix is not needed ? Why would we want to filter out specific value of label AND also empty value

@Rikkuru Rikkuru added the bug Something isn't working right label Feb 29, 2024
@Rikkuru Rikkuru changed the title Regex for empty string |$^ Regex for empty string |$^ in dashboards Feb 29, 2024
@amnonh amnonh removed the bug Something isn't working right label Mar 3, 2024
@amnonh
Copy link
Collaborator

amnonh commented Mar 3, 2024

The reason for accepting data without a cluster label is to support customers who did not configure the cluster label, we may remove it in a future release as it's a breaking changes

@amnonh amnonh added this to the Monitoring 4.7 milestone Mar 7, 2024
@amnonh amnonh added the breaking-changes This change is not backward compatible label Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-changes This change is not backward compatible
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants