Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(hydra): limit tmpfs to 256m #9650

Merged
merged 1 commit into from
Jan 7, 2025
Merged

fix(hydra): limit tmpfs to 256m #9650

merged 1 commit into from
Jan 7, 2025

Conversation

fruch
Copy link
Contributor

@fruch fruch commented Jan 5, 2025 •
edited
Loading

since we are might be running multiple hydra commands on the same jenkins builder, and we are running into those kind of error:

docker: Error response from daemon: failed to create task for container:
failed to create shim task: OCI runtime create failed: runc create failed:
unable to start container process: error during container init:
error mounting "tmpfs" to rootfs at "/home/jenkins/.local":
create mountpoint for /home/jenkins/.local mount:
mkdirat /var/lib/docker/.../.local: file exists: unknown.

we are trying to limit the memory to try to avoid this issue

Fixes: #9645

Testing

  • provision tests

PR pre-checks (self review)

  • I added the relevant backport labels
  • I didn't leave commented-out/debugging code

Reminders

  • Add New configuration option and document them (in sdcm/sct_config.py)
  • Add unit tests to cover my changes (under unit-test/ folder)
  • Update the Readme/doc folder relevant to this change (if needed)

@fruch fruch added test-provision-aws Run provision test on AWS test-provision-gce Run provision test on GCE test-integration Enable running the integration tests suite labels Jan 5, 2025
@fruch fruch requested a review from a team January 5, 2025 14:51
@fruch
Copy link
Contributor Author

fruch commented Jan 6, 2025

integration tests would be fixed by: #9658

not related to this change

vponomaryov
vponomaryov reviewed Jan 6, 2025
View reviewed changes
docker/env/hydra.sh Outdated Show resolved Hide resolved
@fruch
fix(hydra): limit tmpfs to 100m
f99ea30 
since we are might be running multiple hydra commands on
the same jenkins builder, and we are running into those kind
of error:
```
docker: Error response from daemon: failed to create task for container:
failed to create shim task: OCI runtime create failed: runc create failed:
unable to start container process: error during container init:
error mounting "tmpfs" to rootfs at "/home/jenkins/.local":
create mountpoint for /home/jenkins/.local mount:
mkdirat /var/lib/docker/.../.local: file exists: unknown.
```

we are trying to limit the memory to try to avoid this issue

Fixes: scylladb#9645
@fruch fruch requested review from vponomaryov and a team January 6, 2025 22:10
vponomaryov
vponomaryov approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@vponomaryov vponomaryov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

soyacz
soyacz approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@soyacz soyacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

besides commit message wrong number, LGTM

@fruch fruch changed the title fix(hydra): limit tmpfs to 100m fix(hydra): limit tmpfs to 256m Jan 7, 2025
@fruch fruch merged commit 9a73120 into scylladb:master Jan 7, 2025
10 checks passed
This was referenced Jan 7, 2025
Open
Merged
Merged
Merged
Merged
Merged
Merged
@vponomaryov vponomaryov added the backport/2024.2 Need backport to 2024.2 label Jan 7, 2025
@vponomaryov
Copy link
Contributor

😁
Screenshot from 2025-01-07 17-09-52
😁

@mergify mergify bot mentioned this pull request Jan 7, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soyacz soyacz soyacz approved these changes

@vponomaryov vponomaryov vponomaryov approved these changes

Assignees

@fruch fruch

Labels
backport/perf-v15-done backport/perf-v16-done backport/6.0 backport/6.1-done Commit backported to 6.1 backport/6.2-done backport/2023.1 Need to backport to 2023.1 backport/2024.1 Need backport to 2024.1 backport/2024.2-done Commit backported to 2024.2 promoted-to-master test-integration Enable running the integration tests suite test-provision-aws Run provision test on AWS test-provision-gce Run provision test on GCE
Projects
None yet
Milestone
No milestone
4 participants
@fruch @vponomaryov @soyacz @scylladbbot