Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unpin urllib3 once botocore works with urllib3 >= 2.0 #454

Open
tchaikov opened this issue May 10, 2023 · 6 comments
Open

unpin urllib3 once botocore works with urllib3 >= 2.0 #454

tchaikov opened this issue May 10, 2023 · 6 comments
Assignees

Comments

@tchaikov
Copy link
Contributor

because of boto/botocore#2926, we have to peg urllib3 dependency to < 2. see #453.

we might want to undo this once the upstream issues are fixed.

@doc-sheet
Copy link

Yeah.
botocore supports new urllib since 1.34.63
boto/botocore#3141

I guess time has come.

@fruch
Copy link
Contributor

fruch commented Jun 23, 2024

Yeah. botocore supports new urllib since 1.34.63 boto/botocore#3141

I guess time has come.

is that blocking something ? or you just notice it does work now ?

@doc-sheet
Copy link

Kinda - I tried to install ccm as a dependency but urllib3 has been downgraded to old version.
Then I found this issue.

@fruch
Copy link
Contributor

fruch commented Jun 23, 2024

Kinda - I tried to install ccm as a dependency but urllib3 has been downgraded to old version. Then I found this issue.

o.k. one could try it ontop of a PR, and see if it's now works better across all supported python versions

@doc-sheet
Copy link

doc-sheet commented Jun 23, 2024

NB: ccm works fine with latest urllib3/boto3/botocore on python 3.10

@fruch
Copy link
Contributor

fruch commented Jun 23, 2024

NB: ccm works fine with latest urllib3/boto3/botocore on python 3.10

Well if I remember correctly the problem was with python 3.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants