Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pandas 1.3.0 compatibility #1917

Closed
ivirshup opened this issue Jul 5, 2021 · 0 comments · Fixed by #1918
Closed

Pandas 1.3.0 compatibility #1917

ivirshup opened this issue Jul 5, 2021 · 0 comments · Fixed by #1918
Labels
Milestone

Comments

@ivirshup
Copy link
Member

ivirshup commented Jul 5, 2021

We have some failing tests due to a couple bugs introduced in pandas 1.3.0:

I think this one is small in scope. Has problems when df.agg is called, when all columns are categorical and index is non-unique. Definitely a bug in pandas, and I don't think we do this much. Switching to df.apply works around the problem.

Assignment of single columns np.matrix to dataframe columns no longer works as if the matrix were a 1d array. I think this is a bug since it's an undocumented behaviour change. Fixes are pretty easy, since we can just wrap occurrences with np.ravel, however I wouldn't be surprised if there were many places in the codebase that this happened.

I would be good if these didn't happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant