Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): add option to only allow complete series requests #1164

Merged
merged 8 commits into from
Mar 16, 2021

Conversation

TheCatLady
Copy link
Collaborator

@TheCatLady TheCatLady commented Mar 13, 2021

Description

Adds the option to only allow requests for all not-yet-requested seasons (some seasons may already be available or requested, and thus cannot be requested again). By default, partial series requests are permitted.

Also fixes the request button behavior when all season have already been requested but the media is not fully available yet. (The request button will need to be fixed in the future, after a separate seasons/episodes view has been added.)

Screenshot (if UI-related)

image

To-Dos

  • Successful build yarn build
  • Translation keys yarn i18n:extract

Issues Fixed or Closed

@TheCatLady TheCatLady requested a review from sct as a code owner March 13, 2021 03:27
@TheCatLady TheCatLady force-pushed the feature/ui/complete-series-requests-only branch from 67eb2b8 to e5ddc1e Compare March 13, 2021 03:41
@TheCatLady TheCatLady marked this pull request as draft March 13, 2021 04:05
@TheCatLady TheCatLady marked this pull request as ready for review March 13, 2021 04:21
@TheCatLady TheCatLady force-pushed the feature/ui/complete-series-requests-only branch 9 times, most recently from ae0677e to 3a57494 Compare March 16, 2021 03:19
@TheCatLady TheCatLady force-pushed the feature/ui/complete-series-requests-only branch from 3a57494 to aebedd0 Compare March 16, 2021 04:22
@sct sct merged commit 36c00fd into develop Mar 16, 2021
@sct sct deleted the feature/ui/complete-series-requests-only branch March 16, 2021 07:36
@github-actions
Copy link

github-actions bot commented Apr 1, 2021

🎉 This PR is included in version 1.22.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Administrative option to only allow entire TV Show requests
2 participants