Remove compilation feature disable-metadata-hash-check
#833
Conversation
haerdib
added
F7-enhancement
haerdib
changed the title
disable-metadata-hash-check
| mortality_checkpoint: Option<Hash>, | ||
| tip: Tip, | ||
| pub era: Era, | ||
| pub mortality_checkpoint: Option<Hash>, |
There was a problem hiding this comment.
Not sure if it's the best way to make this pub, but the normal getter function names are already taken as setter functions.. and since it does not provide any real functionality, it's basically just a data container. So I don't see the need to keep the inners private.
Happy to adapt if it's not ok.
There was a problem hiding this comment.
How about using pub(crate)?
There was a problem hiding this comment.
Not sure, because if we are able to reuse the struct in a different ExtrinsicParams implementation, then so could others with their specific Runtime implementation.
There was a problem hiding this comment.
Fair point. Then we leave it as is, works for me.
| mortality_checkpoint: Option<Hash>, | ||
| tip: Tip, | ||
| pub era: Era, | ||
| pub mortality_checkpoint: Option<Hash>, |
There was a problem hiding this comment.
How about using pub(crate)?
disable-metadata-hash-checkExtrinsicParamsWithoutHashCheckto still provide an "easy" compatibility with older nodes.