Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the crates.io version numbers for local dependencies #750

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

Niederb
Copy link
Contributor

@Niederb Niederb commented Mar 12, 2024

It is allowed to have the local path as well as the version number in the dependencies. For local builds the path is used (but the version number is still verified) and on crates.io the version number is used.
See also this description:
https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#multiple-locations
This should make releases in the future simpler as we don't have to add the version numbers later. See for example this branch that adds the version numbers:
#742

@Niederb Niederb marked this pull request as ready for review March 12, 2024 14:09
@Niederb Niederb added E1-breaksnothing F9-dependencies Pull requests that update a dependency file labels Mar 12, 2024
@Niederb Niederb requested a review from masapr March 12, 2024 14:11
Copy link
Collaborator

@masapr masapr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty cool. Thank you!

@Niederb Niederb merged commit 2d6c18c into master Mar 13, 2024
59 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E1-breaksnothing F9-dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants