Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node-api: Box Error::DecodeValue and Error::EncodeValue #700

Merged
merged 1 commit into from
Dec 22, 2023
Merged

node-api: Box Error::DecodeValue and Error::EncodeValue #700

merged 1 commit into from
Dec 22, 2023

Conversation

haerdib
Copy link
Contributor

@haerdib haerdib commented Dec 21, 2023 •
edited
Loading

Clippy warned about too large error in node-api, once it was actually run there. Therefore, this PR updates:

  • CI : Now also tests node-api with clippy
  • Adds Box around Decode and EncodeError to constrain the error.

@haerdib haerdib self-assigned this Dec 21, 2023
@haerdib haerdib added F6-optimization This should optimize the performance E2-breaksapi labels Dec 21, 2023
@haerdib haerdib requested a review from masapr December 21, 2023 12:22
@haerdib haerdib marked this pull request as ready for review December 21, 2023 12:22
@haerdib haerdib changed the title node-api: Add Box to Error::DecodeValue and Error::EncodeValue node-api: Box Error::DecodeValue and Error::EncodeValue Dec 21, 2023
@haerdib haerdib merged commit 9ee2cc8 into master Dec 22, 2023
@haerdib haerdib deleted the bh/fix-clippy branch December 22, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masapr masapr masapr approved these changes

Assignees

@haerdib haerdib

Labels
E2-breaksapi F6-optimization This should optimize the performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haerdib @masapr