Provide an async example #551
Conversation
| limitations under the License. | ||
| */ | ||
|
|
||
| //! Very simple example that shows how to fetch chain metadata with async. |
There was a problem hiding this comment.
In get_block.rs, the example description is also about metadata. ;)
There was a problem hiding this comment.
Yeah I took this from the other example. It might be confusing because metadata has a special meaning in the polkadot eco-system. How about just using chain information in both examples?
| @@ -27,6 +28,7 @@ use substrate_api_client::{ | |||
| #[tokio::main] | |||
| async fn main() { | |||
There was a problem hiding this comment.
What do you think: Do we still need the sync variant of get_blocks? We have different sync examples and the difference between sync and async is not that big.
There was a problem hiding this comment.
Initially I thought it would be nice to show that the async version is faster. Unfortunately that's not really the case. The sync has the small advantage of outputting something directly after each getter, so if something fails later on there is at least the output of the previous stuff.
Niederb
force-pushed
the
tn/async-example
branch
from
ad6195a to
6e4f912
Compare
Niederb
force-pushed
the
tn/async-example
branch
from
cfd5757 to
aae0005
Compare
|
Done |
get_blocksexample such that it takes advantage of async by awaiting multiple futures at the same time.get_blocks_async