Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rust toolchain #514

Merged
merged 3 commits into from
Apr 4, 2023
Merged

Update rust toolchain #514

merged 3 commits into from
Apr 4, 2023

Conversation

Niederb
Copy link
Contributor

@Niederb Niederb commented Apr 4, 2023

No description provided.

@Niederb Niederb requested review from haerdib and echevrier April 4, 2023 12:59
haerdib
haerdib approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@haerdib haerdib left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks!

Regarding the Labels: I think the Q labels are only for Issues relevant. I don't see the use case using them for PRs. For releases they are not relevant.

primitives/src/types.rs
pub enum RewardDestination<AccountId> {
/// Pay into the stash account, increasing the amount at stake accordingly.
#[default]
Copy link
Contributor

@haerdib haerdib Apr 4, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow, that's cool! Was that a clippy warning?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, clippy is the best 😄

@haerdib
Copy link
Contributor

haerdib commented Apr 4, 2023 •
edited
Loading

Can you link the associated issue?

echevrier
echevrier approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@echevrier echevrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Niederb Niederb removed the Q0-trivial label Apr 4, 2023
@Niederb Niederb linked an issue Apr 4, 2023 that may be closed by this pull request
Update rust toolchain #497
Closed
@Niederb Niederb merged commit db27986 into master Apr 4, 2023
@Niederb Niederb deleted the tn/update-rust-toolchain branch April 4, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haerdib haerdib haerdib approved these changes

@echevrier echevrier echevrier approved these changes

Assignees
No one assigned
Labels
E1-breaksnothing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update rust toolchain
3 participants
@Niederb @haerdib @echevrier