Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ExtrinsicSigner encoding #510

Merged
merged 2 commits into from
Apr 4, 2023
Merged

Fix ExtrinsicSigner encoding #510

merged 2 commits into from
Apr 4, 2023

Conversation

haerdib
Copy link
Contributor

@haerdib haerdib commented Apr 3, 2023

closes #503

@haerdib haerdib added F2-bug Something isn't working E1-breaksnothing labels Apr 3, 2023
@haerdib haerdib self-assigned this Apr 3, 2023
@haerdib haerdib requested review from Niederb and echevrier April 3, 2023 14:52
echevrier
echevrier approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@echevrier echevrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Niederb
Niederb approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@Niederb Niederb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@haerdib haerdib merged commit 3fc41b5 into master Apr 4, 2023
@haerdib haerdib deleted the bh/fix-signature-encoding branch April 4, 2023 06:53
@haerdib haerdib changed the title Fix Signer encoding Fix ExtrinsicSigner Encoding Apr 4, 2023
@haerdib haerdib changed the title Fix ExtrinsicSigner Encoding Fix ExtrinsicSigner encoding Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Niederb Niederb Niederb approved these changes

@echevrier echevrier echevrier approved these changes

Assignees

@haerdib haerdib

Labels
E1-breaksnothing F2-bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Signature Encoding enforcement
3 participants
@haerdib @Niederb @echevrier