Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add first PR condition to GitHub maintainer workflow #300

Closed
2 tasks done
andrewtavis opened this issue Oct 9, 2024 · 6 comments
Closed
2 tasks done

Add first PR condition to GitHub maintainer workflow #300

andrewtavis opened this issue Oct 9, 2024 · 6 comments
Assignees
Labels
feature New feature or request hacktoberfest Included as a part of Hacktoberfest help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

Terms

Description

One thing that would make the maintainer experience a lot better for Scribe-Data and other projects would be if the .github/workflows/pr_maintainer_checklist.yaml had a conditional for if it's the first pull request to the repository. If it is the first pull request, then we would want the first checkbox to be included, and if not, then the first checkbox should be removed.

In short: The box is very useful for new contributors, but I'd like to stop checking it for people who I know have their account set up properly 😅

Contribution

Would be really happy to review this and see it working!

@andrewtavis andrewtavis added feature New feature or request help wanted Extra attention is needed hacktoberfest Included as a part of Hacktoberfest labels Oct 9, 2024
@axif0
Copy link
Collaborator

axif0 commented Oct 9, 2024

Can we use GitHub Actions expressions to check the pull request number? If it's the first pull request (github.event.pull_request.number == 1), we can include the specific checklist item.

${{ if eq(github.event.pull_request.number, 1) }}
- [ ] The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
 - The contributor's name and icon in remote commits should be the same as what appears in the PR
- If there's a mismatch, the contributor needs to make sure that the [email they use for GitHub](https://github.com/settings/emails) matches what they have for `git config user.email` in their local Scribe-Data repo
${{ endif }}

@andrewtavis
Copy link
Member Author

I think we're looking for more leveraging actions/first-interaction here, @axif0 :) What you suggested is more for the first pull request on the repo, not for the first pull request of a user on the repo 😊

@axif0
Copy link
Collaborator

axif0 commented Oct 9, 2024

@andrewtavis Want to work on this. Can I assign here if there is no problem?

@andrewtavis andrewtavis moved this from Todo to In Progress in Scribe Board Oct 9, 2024
@andrewtavis
Copy link
Member Author

Thanks much, @axif0 :) Once this works, you'd be welcome to change it in other Scribe repos too!

@axif0 axif0 mentioned this issue Oct 10, 2024
1 task
@andrewtavis
Copy link
Member Author

Closed by #308 😊 Thanks a lot, @axif0!

@andrewtavis
Copy link
Member Author

Thanks for all of these, @axif0! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request hacktoberfest Included as a part of Hacktoberfest help wanted Extra attention is needed
Projects
Archived in project
Development

No branches or pull requests

2 participants