Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uploading gifs as costumes imports images in wrong order #5875

Open
BryceLTaylor opened this issue Jun 10, 2020 · 11 comments · Fixed by alx-zhu/scratch-gui-codebb#1 · May be fixed by #9774
Open

Uploading gifs as costumes imports images in wrong order #5875

BryceLTaylor opened this issue Jun 10, 2020 · 11 comments · Fixed by alx-zhu/scratch-gui-codebb#1 · May be fixed by #9774

Comments

@BryceLTaylor
Copy link
Contributor

Expected Behavior

If you import gifs as costumes for a sprite it should import the images in the same order as they appear in the gif.

Actual Behavior

The images appear out of order. We fixed this issue (#4509) for sprite upload, but when you upload a gif as a costume they appear out of order.

related to issues: #3541 and #3254

Steps to Reproduce

Upload a relatively large gif with fluid motion such as this one:
CoolGif
Import the gif as a sprite
Build this stack:
Screen Shot 2020-06-10 at 10 40 26 AM
Click the green flag
Note: the gif plays back smoothly
Now create a new empty sprite
Open the costumes tab
Choose Upload a costume
Choose the same gif
Add the same stack to this sprite
Click the green flag
Note: the gif jumps around because the images have come in out of order.

Here is a project I made to demonstrate, though to see the import behavior you will have to create a new one.

Operating System and Browser

Mac Chrome

@redstone-dev
Copy link

Interesting...

@josiauh
Copy link

josiauh commented Jun 11, 2020

If you don't use the wait block it's faster

@josiauh
Copy link

josiauh commented Jun 11, 2020

and smoothery (i guess)

@BoomerScratch
Copy link

Duplicate of #5138

@BryceLTaylor
Copy link
Contributor Author

@BoomerScratch I ended up closing #5138 since it seemed its repro steps were a little less reliable and this one was already triaged.

@jespino
Copy link

jespino commented Oct 5, 2023

I'm not able to reproduce this bug using firefox in linux. I don't know if this is already fixed, or it is a Mac/Chrome related bug.

@RockGuyDog
Copy link

Bump this is still broken

@fliiiiiiiiiiiiiiiiiiiiiiiiiiiiiiick

bump

@CubicMathTime
Copy link

Bump, big gifs are totally out of order and it takes forever to reorder

@HeidiTao
Copy link

HeidiTao commented Nov 24, 2024

@chrisgarrity We'd like to try working on this! (@alx-zhu @sherryzhuge1 @Victor-Crawshaw @John-Crawshaw)

@alx-zhu
Copy link

alx-zhu commented Dec 8, 2024

Hey @chrisgarrity @BryceLTaylor, we've found a working solution for the gif ordering issues linked in PR #9774! Would appreciate if you took a look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment