Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments in imported project can be removed using undo #1973

Open
mfrtrifork opened this issue Jul 30, 2019 · 1 comment
Open

Comments in imported project can be removed using undo #1973

mfrtrifork opened this issue Jul 30, 2019 · 1 comment

Comments

@mfrtrifork
Copy link
Contributor

Expected Behavior

The history of the project should be cleared and "Undo" button should be disabled.

Actual Behavior

"Undo" button is enabled and removes the comment (moves one comment at a time which is connected to a block).
scratch-comment

Steps to Reproduce

  1. Create a project with comments.
  2. Save to sb3 file
  3. Open file.
  4. Right click and see that undo is enabled.

Operating System and Browser

Mac OS 10.14.4
75.0.3770.142 (Official Build) (64-bit)

@DNin01
Copy link

DNin01 commented Apr 10, 2023

I think Scratch is loading the sprite's content without comments that are attached to blocks and then adding the attached comments afterward which gets recorded in undo history. But when that happens, the content doesn't get saved in undo/redo history, so undoing and then redoing inserts a blank comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants