Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't build app for windows if the app uses netconf driver #55

Closed
idqdq opened this issue Nov 12, 2021 · 3 comments
Closed

can't build app for windows if the app uses netconf driver #55

idqdq opened this issue Nov 12, 2021 · 3 comments

Comments

@idqdq
Copy link

idqdq commented Nov 12, 2021

Hi Carl
this is the follow-up issue I've described in the issue 54

the next issue I ran into - I can't build my app for windows platform
to be honest I've never tried it before so maybe I'm doing something wrong

this is what i was trying to do and the result

> GOOS=windows GOARCH=amd64 go build clear_ipsec.go
# github.com/scrapli/scrapligo/driver/base
../../driver/base/new_windows.go:43:22: d.TimeoutSocket undefined (type *Driver has no field or method TimeoutSocket)
../../driver/base/new_windows.go:44:22: d.TimeoutTransport undefined (type *Driver has no field or method TimeoutTransport)

my code

       d, _ := netconf.NewNetconfDriver(
		"192.168.99.94",
		base.WithAuthStrictKey(false),
		base.WithAuthUsername("clear_ipsec"),
		base.WithAuthPassword("strongpassword"),
		base.WithPort(22),
		//base.WithTimeoutTransport(20),
		//base.WithTimeoutSocket(20),
		base.WithTransportType(transport.StandardTransportName),
	)

	d.Open()

as you can see I've tried to play with Timeouts (commented out) but with no success

@carlmontanari
Copy link
Contributor

👋

Hey Nikolay!

I'll respond to the other issue probably this weekend, but this one was easy enough 😁

You're lucky this was an easy one since I don't care at all about windows hahah. Anyway, just pushed a commit to main branch that should sort it out. Basically was just some cruft that was left over from overhauling some of the transport stuff a few months back. Since I don't care about/test/support windows (and never will!!!!! 🤣 ) it got missed.

Let us know if this commit sorts it out. Basically just setting the defaults instead of assigning from driver object -- then the options get applied toward the end of that function.

Carl

@idqdq
Copy link
Author

idqdq commented Nov 15, 2021

Hi Carl
Yes it does work now
Thx

p.s I like your attitude to windows :)

@carlmontanari
Copy link
Contributor

Awesome, thanks for confirming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants