Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

websocket-client version upgrade #201

Open
hadim opened this issue Nov 14, 2019 · 3 comments · May be fixed by #213
Open

websocket-client version upgrade #201

hadim opened this issue Nov 14, 2019 · 3 comments · May be fixed by #213

Comments

@hadim
Copy link
Contributor

hadim commented Nov 14, 2019

Any reason why the websocket-client version is stuck at 0.44? The current version is 0.56. How hard would it take to upgrade slackbot to 0.56?
@lucywang000
Copy link
Collaborator

what feature do you want from 0.56?

@hadim
Copy link
Contributor Author

hadim commented Nov 19, 2019

None. It's just having an old version could conflict with others dependencies at some point for the conda package: https://github.com/conda-forge/slackbot-feedstock/blob/c7018b3a8e6d995ba53e07cffc3a83dc2ff4bc0e/recipe/meta.yaml#L23

So far there is no issue, I am just trying to anticipate.

@bsima
Copy link

bsima commented Apr 22, 2020

One reason to want a version >0.44 would be to get this feature, which seems pretty useful: websocket-client/websocket-client#415

@bsima bsima linked a pull request Apr 22, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Increase bounds on websocket-client bsima/slackbot
3 participants
@bsima @hadim @lucywang000