Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicates are confusing #131

Closed
manycoding opened this issue Jul 4, 2019 · 0 comments · Fixed by #171
Closed

Duplicates are confusing #131

manycoding opened this issue Jul 4, 2019 · 0 comments · Fixed by #171
Assignees
Labels
Type: Feature New feature or request
Milestone

Comments

@manycoding
Copy link
Contributor

manycoding commented Jul 4, 2019

At the moment, we have 3 rules which do more or less the same, i.e. find duplicate items by column/columns:
https://github.com/scrapinghub/arche/blob/master/src/arche/rules/duplicates.py
find_by (multiple columns support, "Duplicates")
find_by_unique (one field, "Uniqueness/Duplicates By unique Tag")
find_by_name_url (tags, named "Duplicated Items/Duplicates By name_field, product_url_field Tags")

That's confusing. As a part of #123 , I propose to move from tags to arguments which basically removes the need of using tags and obsoletes the last two.

Arche(uniques=["url", ("id", "color")])
single entry url will check that the column contains only unique values
tuple ("id", "color") will check that all rows contain unique combination of id color
@peonone

@manycoding manycoding added the Type: Feature New feature or request label Jul 4, 2019
@manycoding manycoding added this to the 0.3.7 milestone Jul 4, 2019
@manycoding manycoding self-assigned this Oct 11, 2019
@manycoding manycoding mentioned this issue Oct 11, 2019
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant