Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Field counts doesn't trigger error for jobs with lots of NaN #11

Open
manycoding opened this issue Jan 4, 2019 · 1 comment
Open

Field counts doesn't trigger error for jobs with lots of NaN #11

manycoding opened this issue Jan 4, 2019 · 1 comment
Labels
Type: Bug Something isn't working

Comments

@manycoding
Copy link
Contributor 

ghat = Gatf(source='364692/1/17', 
            schema='schemas/Global Strategies/amazon_product.json',
            target='364692/1/14',
#             schema=schema
           )

The price fields here differ on 15% and yet no error in log. Perhaps we don't really want to see an improved coverage?
@manycoding
Copy link
Contributor Author

@alexandr1988 What do you think?

@manycoding manycoding transferred this issue from another repository Mar 18, 2019
@manycoding manycoding added Type: Rule Type: Bug Something isn't working labels Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@manycoding