-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to set parameteres like threshold #102
Comments
It can be:
|
@ejulio Any comments or ideas? |
@manycoding , my idea here is, if it is only a config for Since most of the time arche runs in jupyter notebooks, I don't think an environment variable is a good choice, at least at first. So, my idea of an API would be
Both are fine and can be accomplished by |
@ejulio Do you think these threshold should be treated equally or be separated?
|
IMHO, they should be different.
Though I'm not sure about Maybe
|
A reloadable config or passing arguments is needed, so anybody can set
report_all()
at once:E.g. we have
threshold
for coverage diff, which defaults to 0.2, so the config might look like:The text was updated successfully, but these errors were encountered: