Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Scala 2.13.0-M5 support #234

Closed
gslowikowski opened this issue Sep 23, 2018 · 13 comments
Closed

Add Scala 2.13.0-M5 support #234

gslowikowski opened this issue Sep 23, 2018 · 13 comments
Assignees

Comments

@gslowikowski
Copy link
Member

Waiting for dependencies:

@SethTisue
Copy link

ScalaTest has now published, still waiting on scala-logging

@SethTisue
Copy link

scala-logging has published

@SethTisue
Copy link

SethTisue commented Oct 31, 2018

has publishing happened?

(asking, in part, because this might be a blocker for cats? /cc @kailuowang)

@kailuowang
Copy link

We disabled coverage on 2.13 due to this.
related typelevel/cats#2347

@gslowikowski
Copy link
Member Author

gslowikowski commented Oct 31, 2018

Yes, I released it yesterday.

@SethTisue
Copy link

@gslowikowski would you mind submitting a PR adding it to https://github.com/scala/make-release-notes/blob/2.13.x/projects-2.13.md ? I'm not sure exactly where/how to list it.

@gslowikowski
Copy link
Member Author

Done scala/make-release-notes#286

@SethTisue
Copy link

cool, thanks

@gslowikowski
Copy link
Member Author

Hi @SethTisue

Scala 2.13.0-M5 reports some warnings in scoverage build:

https://travis-ci.org/scoverage/scalac-scoverage-plugin/jobs/448599407#L519-L521
https://travis-ci.org/scoverage/scalac-scoverage-plugin/jobs/448599407#L541-L550

There are two kinds of warnings:

object DeprecatedDoubleOrdering in object Ordering is deprecated (since 2.13.0): 
There are multiple ways to order Doubles (Ordering.Double.TotalOrdering, Ordering.Double.IeeeOrdering). 
Specify one by using a local import, assigning an implicit val, or passing it explicitly. 
See the documentation for details.
class Reporter in package reporters is deprecated (since 2.13.0): Use reflect.internal.Reporter

I cannot find, how to change the code in a backward compatible way (without creating separate source files for Scala 2.13+). Can you help?

@SethTisue
Copy link

it's often not possible to cross-compile without deprecation warnings, this is normal, I'm afraid.

if you prefer to use -Xfatal-warnings, I'd suggest enabling it in 2.11 and/or 2.12 only. in 2.13, you either live with the warnings, or use silencer to suppress them. I'm sorry scalac doesn't offer better control over warning suppression.

separate source files is an option as well, I have seen some projects take that route. not duplicating massive amounts of code, just having small amounts of version specific code in version specific source directories.

@gslowikowski
Copy link
Member Author

I'm not worried about warnings. I'm thinking about the moment when the deprecated classes/syntax will be removed. Will it be version 2.13.0 or later?

@SethTisue
Copy link

ah... anything that says "deprecated (since 2.13.0)" won't be removed until 2.14 at the earliest

@gslowikowski
Copy link
Member Author

Thanks @SethTisue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants