You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The comment in ScoverageSbtPlugin notes that this Thread.sleep(1000) was added to support Windows. Adding a 1s delay to otherwise performant builds is quite noticeable. The plugin could check the platform to avoid slowing down CI/CD, Linux, and Mac builds. Further, perhaps it's worth understanding why this issue is occurring in the first place.
It was added before my time, so I'm really unsure what the back story was. Seeing the comment I'm open to adding a check here for the os and only doing this on windows.
The comment in
ScoverageSbtPlugin
notes that thisThread.sleep(1000)
was added to support Windows. Adding a 1s delay to otherwise performant builds is quite noticeable. The plugin could check the platform to avoid slowing down CI/CD, Linux, and Mac builds. Further, perhaps it's worth understanding why this issue is occurring in the first place.sbt-scoverage/src/main/scala/scoverage/ScoverageSbtPlugin.scala
Lines 216 to 218 in eb406f5
Happy to open a PR, but opened the issue to understand if there was a deeper problem here.
The text was updated successfully, but these errors were encountered: