fix: add support for getting/setting an object with a special constructor (e.g., Date, Blob etc.) #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctor (e.g., Date, Blob etc.) Unit tests: - updated the unit test for getting/setting an object (includes a date field too). - added unit test for getting/setting a date object. Caution: - Does not work for local storage, because it saves everything as a string.
scotttrinh
requested changes
May 12, 2017
src/angular-localForage.js
Outdated
| @@ -171,7 +171,7 @@ | |||
| args = arguments, | |||
| self = this, | |||
| promise; | |||
|
|
|||
There was a problem hiding this comment.
Remove this extra whitespace here, and we should be good to go!
|
@scotttrinh removed the white space in the latest commit. |
|
Thanks @Sadeka for the PR! I'll release a patch now. |
|
@scotttrinh My pleasure! |
|
Can this be pushed out to bower, please? |
|
@kaiukdevelopment Sorry about that! Bad tag name. Should be available now, thanks for pointing this out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.