-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add gradient fill functionality for QR codes #87
Conversation
WuChenDi
commented
Oct 31, 2024
- Introduced gradient-related properties in the QrcodeVue component to allow for customizable QR code appearances.
- Implemented both linear and radial gradient options for enhanced visual appeal.
- Updated the README documentation with examples and instructions for using the gradient features.
- Modified the example project to include controls related to gradient options for user testing and demonstration.
- Introduced gradient-related properties in the QrcodeVue component to allow for customizable QR code appearances. - Implemented both linear and radial gradient options for enhanced visual appeal. - Updated the README documentation with examples and instructions for using the gradient features. - Modified the example project to include controls related to gradient options for user testing and demonstration.
First of all, thanks to @kerimovok for their contribution! These features were developed based on their ideas—I simply organized and submitted the PR for merging into the main branch. For more details, please refer to #78. |
Hi,
|
- Removed the ref wrapping of imageProps, converting it to a plain object for simpler management. - Simplified the assignment logic of imageProps for better readability and maintainability. - Eliminated unnecessary handling of null values to streamline the code.
done |
Hi, We need to check the code and make minimal changes, deleting old fields when changing here. <!-- webpack.html -->
<div class="row mb-3">
<label class="col-sm-2 col-form-label">Foreground:</label>
<div class="col-sm-10">
<input type="color" class="border border-3 rounded" v-model="foreground">
</div>
</div> Sometimes we need to use named parameter arguments so that it is easy to maintain. Also it seems that there are too many parameters, and we need to support the functionality proposed in issue #80 later. There will be too many parameters, so we may need to refactor the documentation.
|
This part can be considered for optimization in the next version. Listing all the props individually feels cumbersome, so I simplified it by passing the entire props object directly. Or do you think it’s necessary to define each one individually?
|
有历史原因,有过滤参数的目的。 |
If continue to add multiple features, it may cause problems, and performance also needs to be considered.
|
I'll continue later tonight.
|
Oh, I’m very sorry. This is my first time contributing a PR to this project, and I wasn’t aware of the historical context here. I have now reverted this part of the logic to keep it consistent with the previous version. |
This thing is a joy, only in code, nothing else, thanks for putting in the effort. Will merge to master branch if there are no major issues. Thanks again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The codes is okay with checked. Will be merged.