fix: metadata definition for ExpressionSetDefinitionVersion

[scolladon]

Explain your changes

---

This is an attempt to fix the metadata definition of ExpressionSetDefinitionVersion

Does this close any currently open issues?

---

closes #959

[codeclimate]

Code Climate has analyzed commit 9383c23 and detected 0 issues on this pull request.

View more on Code Climate.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (dc57d86) to head (9383c23).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main      #965   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           40        40           
  Lines         1018      1018           
  Branches       104       104           
=========================================
  Hits          1018      1018           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[scolladon]

Published under dev-965 npm channel.

$ sfdx plugins:install sfdx-git-delta@dev-965

Hi @PythSomeone !

Here is the PR where the ExpressionSetDefinitionVersion is defined.
Related metadata should still be in the expressionSetVersion folder and end with expressionSetVersion suffix.

IMHO, this metadata kind does not seems to be exposed to the metadata API, only to the tooling API.
But who knows, maybe it will work, let me know the result please!

[PythSomeone]

@scolladon

Both validation and generated delta is correct, no errors were produced and ExpressionSetDefinitionVersion was correctly recognized!

Thanks for quick response :)

[scolladon]

@scolladon

Both validation and generated delta is correct, no errors were produced and ExpressionSetDefinitionVersion was correctly recognized!

Thanks for quick response :)

Just to be sure before merging (it is a bit confusing to me) @PythSomeone
the metadata Xml Name (package.xml) is ExpressionSetDefinitionVersion.
Related metadata should still be in the expressionSetVersion folder and end with expressionSetVersion suffix ? right ? (it is this part confusing me)

[PythSomeone]

@scolladon
I understand your concern. The ExpressionSetDefinitionVersion is vital part of Revenue Cloud, I used sfdx to retrieve it from sandbox, the metadata for it was put in that folder with the suffix you mentioned. The naming confuses me too, but I assume this is how it should be.

[github-actions]

Shipped in release v5.51.1.
You can install the new version using the version number or the latest-rc channel

$ sfdx plugins:install sfdx-git-delta@latest-rc
$ sfdx plugins:install [email protected]

Happy incremental deployment!