Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Expression Set metadatas support #960

Merged
merged 6 commits into from
Dec 12, 2024

Conversation

scolladon
Copy link
Owner

@scolladon scolladon commented Dec 9, 2024

Explain your changes


Support for :

ContextDefinition
ExpressionSetMessageToken
ExpressionSetObjectAlias
ProductSpecificationType
ProductSpecificationRecType
UiFormatSpecificationSet
ExpressionSetVersion (not described in the metadata API documentation but available through it)

Does this close any currently open issues?


closes #959

@scolladon scolladon requested a review from mehdicherf as a code owner December 9, 2024 09:48
@scolladon
Copy link
Owner Author

Hi @PythSomeone !

Could you test on your side and help us validate this PR please ?
You can follow those steps to easily do it on your side

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7664f66) to head (9060220).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #960   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           40        40           
  Lines         1018      1018           
  Branches       104       104           
=========================================
  Hits          1018      1018           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scolladon scolladon force-pushed the feat/support-ContextDefinitions-metadata branch from a11e46e to 86a761d Compare December 9, 2024 14:59
@PythSomeone
Copy link
Contributor

@scolladon
Delta correctly recognized changes on ContextDefinition but failed to include the ExpressionSetDefinitionVersion

@scolladon
Copy link
Owner Author

@scolladon Delta correctly recognized changes on ContextDefinition but failed to include the ExpressionSetDefinitionVersion

Do you have an example of ExpressionSetDefinitionVersion from the metadata please ?
I cannot find any reference to in the metadata api documentation. It seems to be included directly inside ExpressionSetDefinition and only available via the Tooling API.

@scolladon
Copy link
Owner Author

FYI @PythSomeone: Product Catalog Management metadata have been added (ProductSpecificationType and ProductSpecificationRecType)

@scolladon
Copy link
Owner Author

Hi @PythSomeone !

Have you been able to look at my question here ?
And also could you test the Product Catalog Management metadata added in this PR and let me know please ?

@PythSomeone
Copy link
Contributor

Hi @scolladon
Here is the path for the metadata in question force-app\main\default\expressionSetVersion\Product_Discovery_Pricing_Procedure_V1.expressionSetVersion-meta.xml

As for (ProductSpecificationType and ProductSpecificationRecType) - they are properly generated by Delta

Copy link

codeclimate bot commented Dec 11, 2024

Code Climate has analyzed commit 9060220 and detected 0 issues on this pull request.

View more on Code Climate.

@scolladon
Copy link
Owner Author

Hi @PythSomeone, thanks for your feedback and for the information.
ExpressionSetVersion has been added and is ready for testing here

Hi @eqtkram, UiFormatSpecificationSet has been added and is ready for testing as well.
Follow information from this comment to test locally.

@PythSomeone
Copy link
Contributor

@scolladon Looks like all the objects I concerned about are now correctly generated in delta. Thanks a lot!

@scolladon scolladon merged commit 6988778 into main Dec 12, 2024
20 of 22 checks passed
@scolladon scolladon deleted the feat/support-ContextDefinitions-metadata branch December 12, 2024 14:16
Copy link

Shipped in release v5.51.0.
You can install the new version using the version number or the latest-rc channel

$ sfdx plugins:install sfdx-git-delta@latest-rc
$ sfdx plugins:install [email protected]

Happy incremental deployment!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expression Set Version and Context Definitions metadata support
2 participants