Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update dependencies #180

Merged
merged 2 commits into from
May 2, 2024
Merged

build: update dependencies #180

merged 2 commits into from
May 2, 2024

Conversation

jamacku
Copy link
Member

@jamacku jamacku commented May 2, 2024

No description provided.

@jamacku jamacku added the type: dependencies Pull requests that update a dependency file label May 2, 2024
@jamacku jamacku requested a review from phracek May 2, 2024 10:31
Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.32%. Comparing base (7bc5ccc) to head (1e71141).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #180       +/-   ##
===========================================
- Coverage   99.50%   88.32%   -11.19%     
===========================================
  Files           8       10        +2     
  Lines         608      685       +77     
  Branches       68       70        +2     
===========================================
  Hits          605      605               
- Misses          3       78       +75     
- Partials        0        2        +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phracek
Copy link
Member

phracek commented May 2, 2024

[test]

Copy link
Member

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks. Let's wait for Testing Farm tests.

@jamacku
Copy link
Member Author

jamacku commented May 2, 2024

[test]

1 similar comment
@phracek
Copy link
Member

phracek commented May 2, 2024

[test]

@jamacku jamacku force-pushed the deps branch 3 times, most recently from 078afbd to 8b7ee77 Compare May 2, 2024 11:00
@phracek
Copy link
Member

phracek commented May 2, 2024

Let's one more round

[test]

@jamacku jamacku marked this pull request as draft May 2, 2024 11:04
@phracek
Copy link
Member

phracek commented May 2, 2024

[test]

@jamacku jamacku marked this pull request as ready for review May 2, 2024 11:22
@phracek
Copy link
Member

phracek commented May 2, 2024

This issue block Timeout test. Let's get merge it. Testing Farm has a bit outage for public ranch.

@phracek phracek merged commit 3035cc0 into sclorg:main May 2, 2024
6 of 11 checks passed
phracek pushed a commit to phracek/testing-farm-as-github-action that referenced this pull request May 2, 2024
* build: update dependencies

* ci: get rid of ESLint, tsc already does the job
@jamacku jamacku deleted the deps branch May 2, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants