Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support path in tmt repository with metadata. #147

Merged
merged 3 commits into from
Apr 11, 2024
Merged

Conversation

phracek
Copy link
Member

@phracek phracek commented Apr 3, 2024

This pull request adds posibility in case of FMF plans are not stored in 'root' directory. Default tmt_path directory is '.'.

See e.g. https://gitlab.cee.redhat.com/rhinstaller/builders
and plans are stored in directory https://gitlab.cee.redhat.com/rhinstaller/builders/-/tree/master/ansible?ref_type=heads.

See FMF process documentation here: https://docs.testing-farm.io/Testing%20Farm/0.1/test-process.html

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.32%. Comparing base (a63195b) to head (1e9373c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #147   +/-   ##
=======================================
  Coverage   99.31%   99.32%           
=======================================
  Files           8        8           
  Lines         584      592    +8     
  Branches       67       69    +2     
=======================================
+ Hits          580      588    +8     
  Misses          4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phracek phracek force-pushed the add_path_option branch 2 times, most recently from 3ac8a48 to 32fa47c Compare April 3, 2024 13:14
@phracek
Copy link
Member Author

phracek commented Apr 3, 2024

This PR is needed by rhinstaller/kickstart-tests#1122

@zmiklank
Copy link
Collaborator

zmiklank commented Apr 5, 2024

[test]

@phracek
Copy link
Member Author

phracek commented Apr 9, 2024

@zmiklank Can we merge it?

Default is ".", root directory

Signed-off-by: Petr "Stone" Hracek <[email protected]>
@phracek
Copy link
Member Author

phracek commented Apr 11, 2024

[test]

README.md Outdated Show resolved Hide resolved
Copy link
Member

@jamacku jamacku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phracek Please also update action.test.ts to use INPUT_TMT_PATH

phracek and others added 2 commits April 11, 2024 15:42
Co-authored-by: Jan Macku <[email protected]>
Default is ".", root directory

Signed-off-by: Petr "Stone" Hracek <[email protected]>
@phracek
Copy link
Member Author

phracek commented Apr 11, 2024

[test]

Copy link
Member

@jamacku jamacku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamacku jamacku added the type: feature New feature or request label Apr 11, 2024
@phracek phracek merged commit c707579 into main Apr 11, 2024
11 checks passed
@phracek phracek deleted the add_path_option branch April 11, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review type: feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants