Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building 2.7 app with Gunicorn fails with syntax error #117

Closed
mnagy opened this issue May 31, 2016 · 5 comments
Closed

Building 2.7 app with Gunicorn fails with syntax error #117

mnagy opened this issue May 31, 2016 · 5 comments
Assignees

Comments

@mnagy
Copy link
Contributor

mnagy commented May 31, 2016

$ s2i build git://github.com/mnagy/stress_test centos/python-27-centos7 python-sample-app  --context-dir=sti-python/test-app
I0531 08:20:51.853106 30506 clone.go:31] Downloading "git://github.com/mnagy/stress_test" ("sti-python/test-app") ...
I0531 08:20:52.638103 30506 install.go:251] Using "assemble" installed from "image:///usr/libexec/s2i/assemble"
I0531 08:20:52.638170 30506 install.go:251] Using "run" installed from "image:///usr/libexec/s2i/run"
I0531 08:20:52.638211 30506 install.go:251] Using "save-artifacts" installed from "image:///usr/libexec/s2i/save-artifacts"
---> Copying application source ...
---> Installing dependencies ...
Downloading/unpacking gunicorn (from -r requirements.txt (line 1))
Installing collected packages: gunicorn
Compiling /tmp/pip-build-izJkqx/gunicorn/gunicorn/workers/_gaiohttp.py ...
File "/tmp/pip-build-izJkqx/gunicorn/gunicorn/workers/_gaiohttp.py", line 84
yield from self.wsgi.close()
^
SyntaxError: invalid syntax

Successfully installed gunicorn
Cleaning up...
@soltysh
Copy link
Contributor

soltysh commented May 31, 2016

See this comment, but the general take-away is we need newer version of pip, which ignores that error. I've just tried it and it works with pip 8.1.2. @hhorak is update of pip possible in scl? @mnagy have you tried other versions/images, does it apply there as well?

@mnagy
Copy link
Contributor Author

mnagy commented Jun 1, 2016

@soltysh nice, thanks for finding that! Yes, I tried and they work well. And actually, I realized later that this error message does not fail building the image, so it actually works ok. Would be nice to get rid of it, however.

@soltysh
Copy link
Contributor

soltysh commented Jun 1, 2016

👍 for getting rid of it.

@hhorak
Copy link
Member

hhorak commented Jun 10, 2016

We'll track pip update in this BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1344674

@pkubatrh
Copy link
Member

pkubatrh commented Feb 6, 2017

Closing via #159

@pkubatrh pkubatrh closed this as completed Feb 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants