Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use ext name instead of pkg name, and add redis #479

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

remicollet
Copy link
Contributor

@remicollet remicollet commented Jan 30, 2025

Main benefit: will install the extension, whatever the package name is, and latest version, ex:

  • zip => php-zip => php-pecl-zip
  • json => php-pecl-json => php-json => php-common (since 8.0)
  • redis => php-pecl-redis3 => php-pecl-redis5 => php-pecl-redis6
  • etc

By packaging Guidelines, the php-<extname> is always provided and is the only reliable name
https://docs.fedoraproject.org/en-US/packaging-guidelines/PHP/#requires-provides-c

Copy link

github-actions bot commented Jan 30, 2025

Pull Request validation

Success

🟢 CI - All checks have passed
🟢 Review - Reviewed by a member
🟢 Approval - Changes were approved


Auto Merge

Failed

🔴 Pull Request has unsupported target branch master, expected branches are: ''

Success

🟢 Pull Request is not marked as draft and it's not blocked by dont-merge label
🟢 Pull Request meet requirements, title has correct form
🟢 Pull Request meet requirements, mergeable is true
🟢 Pull Request meet requirements, mergeable_state is clean

@remicollet
Copy link
Contributor Author

@phracek please check

@phracek
Copy link
Member

phracek commented Jan 30, 2025

[test]

Copy link

github-actions bot commented Jan 30, 2025

Testing Farm results

namecomposearchstatusstarted (UTC)timelogs
CentOS Stream 10 - 8.3CentOS-Stream-10x86_64✅ passed30.01.2025 15:53:548min 1stest pipeline
Fedora - 8.3Fedora-latestx86_64✅ passed30.01.2025 15:53:5810min 39stest pipeline
Fedora - 8.1Fedora-latestx86_64✅ passed30.01.2025 15:53:4610min 28stest pipeline
Fedora - 8.2Fedora-latestx86_64✅ passed30.01.2025 15:53:5310min 30stest pipeline
RHEL9 - 8.2RHEL-9.4.0-Nightlyx86_64✅ passed30.01.2025 15:53:5513min 35stest pipeline
RHEL9 - 8.0RHEL-9.4.0-Nightlyx86_64✅ passed30.01.2025 15:53:4913min 41stest pipeline
RHEL9 - 8.1RHEL-9.4.0-Nightlyx86_64✅ passed30.01.2025 15:53:5014min 20stest pipeline
RHEL8 - 8.2RHEL-8.10.0-Nightlyx86_64✅ passed30.01.2025 15:53:5415min 40stest pipeline
RHEL8 - 7.4RHEL-8.10.0-Nightlyx86_64✅ passed30.01.2025 15:53:4815min 39stest pipeline

@phracek
Copy link
Member

phracek commented Jan 30, 2025

@remicollet IT looks like on CentOS Stream 10 packages do not exist

package php-apcu is not installed
package php-zip is not installed
package php-redis is not installed

@remicollet
Copy link
Contributor Author

[test]

@remicollet
Copy link
Contributor Author

@remicollet IT looks like on CentOS Stream 10 packages do not exist

package php-apcu is not installed
package php-zip is not installed
package php-redis is not installed

Yes, because these are NOT package name (so rpm -V fails)
Second commit try to fix this

@remicollet
Copy link
Contributor Author

remicollet commented Jan 30, 2025

From CI log:

Found VERSION 8.3
Found requested extensions

:)

@phracek
Copy link
Member

phracek commented Jan 30, 2025

Thanks. Let's try another shot

[test]

@phracek
Copy link
Member

phracek commented Jan 30, 2025

@remicollet One more question. The Dockerfile.rhel10 is not valid? Thanks for the great work, though.

@phracek phracek self-requested a review January 31, 2025 08:38
Copy link
Member

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing. LGTM.

@phracek phracek merged commit 7c17cfe into sclorg:master Jan 31, 2025
10 checks passed
phracek added a commit that referenced this pull request Jan 31, 2025
phracek added a commit that referenced this pull request Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants