Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Fedora NodeJS container so tests passed #467

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Fix Fedora NodeJS container so tests passed #467

merged 3 commits into from
Jan 7, 2025

Conversation

phracek
Copy link
Member

@phracek phracek commented Jan 6, 2025 •
edited by github-actions bot
Loading

NodeJS 22 Fedora container does not install nodejs package and therefore /usr/bin/node and the others are not present.

The commit is simple and fix the problem during build of NodeJS 22 and NodeJS 22-minimal container.
We do not install nodejs package that contains /usr/bin/node file and the rest.
Therefore build is failing.
This fixes the problem.

@phracek
NodeJS 22 Fedora container does not install nodejs package
2a11f2d 
and therefore /usr/bin/node and the others are not present.

Signed-off-by: Petr "Stone" Hracek <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2025 •
edited
Loading

Pull Request validation

Failed

🔴 Failed or pending statuses - Testing Farm - RHEL9 - 18[error],Testing Farm - RHEL8 - 20-minimal[error],Testing Farm - Fedora - 22[error],Testing Farm - RHEL9 - 20[error],Testing Farm - CentOS Stream 10 - 22-minimal[error],Testing Farm - RHEL9 - 18-minimal[error],Testing Farm - Fedora - 20[error],Testing Farm - RHEL8 - 20[error],Testing Farm - Fedora - 18[error],Testing Farm - Fedora - 18-minimal[error],Testing Farm - CentOS Stream 9 - 20-minimal[error],Testing Farm - Fedora - 22-minimal[error],Testing Farm - RHEL8 - 18[error],Testing Farm - CentOS Stream 9 - 20[error],Testing Farm - RHEL8 - 18-minimal[error],Testing Farm - Fedora - 20-minimal[error],Testing Farm - CentOS Stream 10 - 22[error],Testing Farm - RHEL9 - 22[error],Testing Farm - RHEL9 - 20-minimal[error]
🔴 Review - Missing review from a member (2 required)

@phracek
Copy link
Member Author

phracek commented Jan 6, 2025

Let's run only container tests

[test]

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2025 •
edited
Loading

Testing Farm results

namecomposearchstatusstarted (UTC)timelogs
CentOS Stream 9 - 20CentOS-Stream-9x86_64❌ error06.01.2025 14:59:1013min 11stest pipeline
CentOS Stream 9 - 20-minimalCentOS-Stream-9x86_64❌ error06.01.2025 14:23:364min 37stest pipeline
CentOS Stream 10 - 22-minimalCentOS-Stream-10x86_64❌ error06.01.2025 14:59:237min 44stest pipeline
CentOS Stream 10 - 22CentOS-Stream-10x86_64❌ error06.01.2025 14:59:219min 47stest pipeline
Fedora - 18-minimalFedora-latestx86_64❌ error06.01.2025 14:59:0914min 46stest pipeline
Fedora - 22-minimalFedora-latestx86_64❌ error06.01.2025 14:59:4314min 34stest pipeline
RHEL9 - 18RHEL-9.4.0-Nightlyx86_64❌ error06.01.2025 14:59:0817min 34stest pipeline
RHEL9 - 18-minimalRHEL-9.4.0-Nightlyx86_64❌ error06.01.2025 14:59:1417min 57stest pipeline
RHEL8 - 18-minimalRHEL-8.10.0-Nightlyx86_64❌ error06.01.2025 14:23:3918min 32stest pipeline
Fedora - 22Fedora-latestx86_64✅ passed06.01.2025 14:23:4318min 8stest pipeline
Fedora - 18Fedora-latestx86_64❌ error06.01.2025 14:59:1217min 56stest pipeline
RHEL9 - 22-minimalRHEL-9.4.0-Nightlyx86_64✅ passed06.01.2025 14:25:0918min 4stest pipeline
RHEL9 - 20RHEL-9.4.0-Nightlyx86_64✅ passed06.01.2025 14:23:3819min 16stest pipeline
Fedora - 20Fedora-latestx86_64✅ passed06.01.2025 14:23:3519min 48stest pipeline
RHEL8 - 18RHEL-8.10.0-Nightlyx86_64✅ passed06.01.2025 14:23:3719min 43stest pipeline
RHEL9 - 22RHEL-9.4.0-Nightlyx86_64✅ passed06.01.2025 14:23:4621min 49stest pipeline
RHEL8 - 20RHEL-8.10.0-Nightlyx86_64✅ passed06.01.2025 14:23:3622min 8stest pipeline
Fedora - 20-minimalFedora-latestx86_64✅ passed06.01.2025 14:23:3823min 57stest pipeline
RHEL9 - 20-minimalRHEL-9.4.0-Nightlyx86_64✅ passed06.01.2025 14:23:3925min 54stest pipeline
RHEL8 - 20-minimalRHEL-8.10.0-Nightlyx86_64✅ passed06.01.2025 14:23:3628min 30stest pipeline

@phracek
Stop container only in case of $cid_file is present.
334b32a 
Otherwise it does not make sense to stop container
with non-existing file

Signed-off-by: Petr "Stone" Hracek <[email protected]>
@phracek
Copy link
Member Author

phracek commented Jan 6, 2025

Let's test it again after fix with stoping container that CID file is not exists.

[test]

@phracek phracek requested review from lholmquist, hhorak, pkubatrh and SlouchyButton and removed request for pkubatrh January 6, 2025 15:00
@phracek
Copy link
Member Author

phracek commented Jan 6, 2025

@pacostas Please review it as well. Thanks.

@phracek
Copy link
Member Author

phracek commented Jan 7, 2025 •
edited
Loading

Fixing 20-minimal container and fix 'kill-test-application'

@phracek
Fix symlinks in 20-minimal container.
47f9641 
During 'kill-test-application' we just need
docker kill and 'rm $cid_file' is not needed.

Signed-off-by: Petr "Stone" Hracek <[email protected]>
@phracek phracek force-pushed the fix_fedora_containers branch from 66f278e to 47f9641 Compare January 7, 2025 11:56
@phracek
Copy link
Member Author

phracek commented Jan 7, 2025

[test]

pacostas
pacostas approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@pacostas pacostas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamacku
Copy link
Member

jamacku commented Jan 7, 2025

[test]

@phracek phracek merged commit 68206f1 into master Jan 7, 2025
18 of 21 checks passed
@phracek phracek deleted the fix_fedora_containers branch January 7, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacostas pacostas pacostas approved these changes

@lholmquist lholmquist Awaiting requested review from lholmquist

@hhorak hhorak Awaiting requested review from hhorak

@SlouchyButton SlouchyButton Awaiting requested review from SlouchyButton

Assignees
No one assigned
Labels
pr/failing-ci pr/missing-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phracek @jamacku @pacostas