-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for building and testing PSQL-16 on C10S replace nss-wrapper with nss-wrapper-libs #587
Conversation
[test] |
7e50a58
to
434c430
Compare
[test] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only change that seems to be worth doing is simplifying INSTALL_PKGS
definition and remove the rhscl specifics (brew links etc.) and since we have gettext-envsubst
available in the RHEL-10/c10s, and nss_wrapper-libs
everywhere now, we might simplify it to:
RUN {{ spec.environment_setup }}
{% if spec.prod in [ "rhel8", "rhel9", "c9s" ] %}
INSTALL_PKGS="rsync tar gettext bind-utils nss_wrapper-libs {{ spec.pkgs }}" && \
{% else %}
INSTALL_PKGS="rsync tar gettext-envsubst bind-utils nss_wrapper-libs {{ spec.pkgs }}" && \
{% endif %}
(have not tried yet, mentioning to better describe my intention)
@hhorak It cannot be used because the module is unavailable for C10S. I will fix it good catch. |
[test] |
927b6e3
to
13d5891
Compare
[test-all] |
Fedora 15 has failed for this reason:
CEntOS Stream 10 - 16 has failed for this reason:
The complete results for CentOS Stream 10 are:
|
Signed-off-by: Petr "Stone" Hracek <[email protected]>
Signed-off-by: Petr "Stone" Hracek <[email protected]>
Signed-off-by: Petr "Stone" Hracek <[email protected]>
Signed-off-by: Petr "Stone" Hracek <[email protected]>
Signed-off-by: Petr "Stone" Hracek <[email protected]>
Signed-off-by: Petr "Stone" Hracek <[email protected]>
Signed-off-by: Petr "Stone" Hracek <[email protected]>
Signed-off-by: Petr "Stone" Hracek <[email protected]>
Signed-off-by: Petr "Stone" Hracek <[email protected]>
The failure on C10S is:
|
Signed-off-by: Petr "Stone" Hracek <[email protected]>
Signed-off-by: Petr "Stone" Hracek <[email protected]>
13d5891
to
c57d4e7
Compare
[test] |
CentOS Stream 10 passed. We are GREEN. |
[test] |
@hhorak @SlouchyButton Ready to re-review and merge. C10S passed. |
ee38bbe
to
2ecefea
Compare
[test] |
Signed-off-by: Petr "Stone" Hracek <[email protected]>
2ecefea
to
5ae39e7
Compare
[test] |
868f69c
to
67736ec
Compare
Fix package dependencies |
Add PSQL_PKGS as alone variable Signed-off-by: Petr "Stone" Hracek <[email protected]>
67736ec
to
21c1929
Compare
[test] |
This pull request allows to build and test PSQL-16 on C10S
The pull request is separated into more commits: