Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PostgreSQL Fedora images update #583

Merged
merged 7 commits into from
Sep 6, 2024
Merged

PostgreSQL Fedora images update #583

merged 7 commits into from
Sep 6, 2024

Conversation

phracek
Copy link
Member

@phracek phracek commented Aug 6, 2024

This pull request fixes several issues:

PSQL16 is bump to F40,
PSQL12 and PSQL13 are not build and tested on Fedora. Fedora 38 has reached EOL already.

The same is valid also for PSQL14.

@phracek phracek changed the title Bump PostgreSQL16 Fedora s2i-core image to 40 PostgreSQL Fedora images update Sep 6, 2024
@phracek phracek requested review from hhorak and fila43 September 6, 2024 10:04
It is based on F38 that has already reached EOL

Signed-off-by: Petr "Stone" Hracek <[email protected]>
Signed-off-by: Petr "Stone" Hracek <[email protected]>
@phracek
Copy link
Member Author

phracek commented Sep 6, 2024

[test]

Signed-off-by: Petr "Stone" Hracek <[email protected]>
@phracek
Copy link
Member Author

phracek commented Sep 6, 2024

Fix package names for Fedora 40.

[test]

Signed-off-by: Petr "Stone" Hracek <[email protected]>
@phracek
Copy link
Member Author

phracek commented Sep 6, 2024

In postgresql container is function called 'wait_ready' that checks if container is up. But if checks it forever. We should fail after sometime.

[test]

src/Dockerfile.fedora Outdated Show resolved Hide resolved
src/Dockerfile.fedora Outdated Show resolved Hide resolved
Copy link
Member

@hhorak hhorak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one nitpick about using variable instead of hard-coding 15. Otherwise merge-able from my PoV.

@phracek
Copy link
Member Author

phracek commented Sep 6, 2024

[test-all]

@phracek phracek merged commit 0909678 into master Sep 6, 2024
6 of 28 checks passed
@phracek phracek deleted the update_psql_16_f40 branch September 6, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants