Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support building and testing PostgreSQL-16 #548

Merged
merged 9 commits into from
Feb 12, 2024

Conversation

phracek
Copy link
Member

@phracek phracek commented Jan 9, 2024

This pull request enables building and testing PostgreSQL-16.

The first commit modifies sources to enable building and testing.
The second commit adds dist-gen generated source for postgresql-16

Signed-off-by: Petr "Stone" Hracek <[email protected]>
Signed-off-by: Petr "Stone" Hracek <[email protected]>
@phracek
Copy link
Member Author

phracek commented Jan 9, 2024

This PR is blocked by #547

@hhorak
Copy link
Member

hhorak commented Jan 9, 2024

In order to have PostgreSQL 16 in Fedora, we need to use Fedora 39 as the base, it seems that Fedora 38 is used currently and there is no PostgreSQL 16 there. Plus, we need to use postgresql16-server as the packages to be installed on Fedora 39.

@phracek
Copy link
Member Author

phracek commented Jan 9, 2024

Fedora failure is known:

Error:
 Problem: package pgaudit-1.7.0-5.fc39.x86_64 from fedora requires postgresql-server(:MODULE_COMPAT_15), but none of the providers can be installed
  - package postgresql-server-15.4-1.fc39.i686 from fedora requires postgresql(x86-32) = 15.4-1.fc39, but none of the providers can be installed
  - package postgresql-server-15.4-1.fc39.x86_64 from fedora requires postgresql(x86-64) = 15.4-1.fc39, but none of the providers can be installed
  - package postgresql16-16.1-1.fc39.x86_64 from updates conflicts with postgresql provided by postgresql-15.4-1.fc39.i686 from fedora
  - package postgresql16-16.1-1.fc39.x86_64 from updates conflicts with postgresql provided by postgresql-15.4-1.fc39.x86_64 from fedora
  - package postgresql16-contrib-16.1-1.fc39.x86_64 from updates requires postgresql16(x86-64) = 16.1-1.fc39, but none of the providers can be installed
  - conflicting requests
  - 
  - ```

@phracek
Copy link
Member Author

phracek commented Jan 9, 2024

In order to have PostgreSQL 16 in Fedora, we need to use Fedora 39 as the base, it seems that Fedora 38 is used currently and there is no PostgreSQL 16 there. Plus, we need to use postgresql16-server as the packages to be installed on Fedora 39.

@hhorak This commit should fix it d855c56. And generated source is here: 1fb430a

[test]

@phracek
Copy link
Member Author

phracek commented Jan 9, 2024

The corresponding bugzilla is: https://bugzilla.redhat.com/show_bug.cgi?id=2255013

specs/multispec.yml Outdated Show resolved Hide resolved
specs/multispec.yml Outdated Show resolved Hide resolved
@fila43
Copy link
Member

fila43 commented Jan 18, 2024

Once this update is pushed, Fedora test should pass

Fedora failure is known:

Error:
 Problem: package pgaudit-1.7.0-5.fc39.x86_64 from fedora requires postgresql-server(:MODULE_COMPAT_15), but none of the providers can be installed
  - package postgresql-server-15.4-1.fc39.i686 from fedora requires postgresql(x86-32) = 15.4-1.fc39, but none of the providers can be installed
  - package postgresql-server-15.4-1.fc39.x86_64 from fedora requires postgresql(x86-64) = 15.4-1.fc39, but none of the providers can be installed
  - package postgresql16-16.1-1.fc39.x86_64 from updates conflicts with postgresql provided by postgresql-15.4-1.fc39.i686 from fedora
  - package postgresql16-16.1-1.fc39.x86_64 from updates conflicts with postgresql provided by postgresql-15.4-1.fc39.x86_64 from fedora
  - package postgresql16-contrib-16.1-1.fc39.x86_64 from updates requires postgresql16(x86-64) = 16.1-1.fc39, but none of the providers can be installed
  - conflicting requests
  - 
  - ```

Signed-off-by: Petr "Stone" Hracek <[email protected]>
Signed-off-by: Petr "Stone" Hracek <[email protected]>
@phracek
Copy link
Member Author

phracek commented Jan 25, 2024

[test]

1 similar comment
@zmiklank
Copy link
Contributor

[test]

@phracek
Copy link
Member Author

phracek commented Feb 5, 2024

[test]

@phracek
Copy link
Member Author

phracek commented Feb 7, 2024

Another Fedora update for postgresql16-pgaudit https://bodhi.fedoraproject.org/updates/FEDORA-2024-e86c64a60b

@phracek
Copy link
Member Author

phracek commented Feb 9, 2024

Fedora fix is already stable. Thanks @fila43 . Let's try to re-run tests.

[test]

@zmiklank
Copy link
Contributor

zmiklank commented Feb 9, 2024

Patch like this is needed (use postgresql16-pgaudit, instead of pgaudit for postgresql 16 in fedora):

diff --git a/src/Dockerfile.fedora b/src/Dockerfile.fedora
index 806621e..ad8e03e 100644
--- a/src/Dockerfile.fedora
+++ b/src/Dockerfile.fedora
@@ -54,9 +54,12 @@ RUN INSTALL_PKGS="rsync tar gettext bind-utils postgresql16-server postgresql16-
 RUN INSTALL_PKGS="rsync tar gettext bind-utils postgresql-server postgresql-contrib nss_wrapper " && \
 {% endif %}
     INSTALL_PKGS+="findutils xz" && \
-{% if spec.version not in ["9.6", "10", "11"] %}
+{% if spec.version not in ["9.6", "10", "11", "16"] %}
     INSTALL_PKGS+=" pgaudit" && \
 {% endif %}
+{% if spec.version == "16" %}
+    INSTALL_PKGS+=" postgresql16-pgaudit" && \
+{% endif %}
 {% if spec.version not in ["16"] %}
     dnf -y module enable postgresql:{{ spec.version }} && \
 {% endif %}

@phracek
Copy link
Member Author

phracek commented Feb 12, 2024

[test]

@phracek phracek merged commit 3f3a619 into master Feb 12, 2024
25 checks passed
@phracek phracek deleted the support_build_test_psql_16 branch February 12, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants