Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling point compression in proving key serialization #28

Open
ebfull opened this issue May 8, 2016 · 3 comments
Open

Disabling point compression in proving key serialization #28

ebfull opened this issue May 8, 2016 · 3 comments

Comments

@ebfull
Copy link

ebfull commented May 8, 2016

Large constraint systems mean huge proving keys, and with point compression enabled, loading those keys takes several minutes. Right now you can only enable point compression across the board, and it could be tricky to refactor that. Perhaps it should be made into a global that can be selectively disabled/enabled by the end user?

@daira
Copy link

daira commented May 9, 2016

Specifically, I think we need to be able to enable compression for proofs, but disable it for the proving key.

@tromer
Copy link
Member

tromer commented May 22, 2016

Makes sense. But de/compression happens deep inside the context-independent de/serialization code. Controlling it via a global that changes the interpretation of all streams is pretty scary.

C++ streams supports a notion of flags (setf() etc.), which would have been nice, but it's not extendible.

@daira
Copy link

daira commented Aug 8, 2016

The [de]serialisation of proofs doesn't necessarily have to be done using the stream operators.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants