Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect errorMessage returned when users cancelled a tx #35

Closed
ical10 opened this issue Oct 16, 2023 · 2 comments
Closed

Incorrect errorMessage returned when users cancelled a tx #35

ical10 opened this issue Oct 16, 2023 · 2 comments

Comments

@ical10
Copy link
Contributor

ical10 commented Oct 16, 2023

When users cancelled a tx, ContractResult returns 'Error' instead of 'UserCancelled' as the errorMessage.
@wottpal wottpal moved this from 🆕 New to 📋 Backlog in ink!athon Backlog Oct 20, 2023
@wottpal wottpal moved this from 📋 Backlog to 👀 In review in ink!athon Backlog Oct 26, 2023
@wottpal
Copy link
Member

wottpal commented Oct 26, 2023 •
edited
Loading

@ical10 Can you check if this is fixed for azero-id frontend & ink!athon for you as well with [email protected] (see release)? Also do some rough tests as usually regarding the touched parts (i.e. contractTx).

@ical10
Copy link
Contributor Author

ical10 commented Oct 26, 2023

@wottpal just checked both dapps locally with [email protected]: I can confirm it solved this issue, and contractTx is working as expected.

ink!athon

inkathon-success-tx
inkathon-cancelled-tx

azero-id

azero-id-success-tx
azero-id-cancelled-tx

@wottpal wottpal closed this as completed Oct 26, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in ink!athon Backlog Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
ink!athon Backlog
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wottpal @ical10