Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split transforms into 2 inputs and update versions in registrations/antsapplytransforms #55

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

gagnonanthony
Copy link
Contributor

Splitted the transform files in input into two different inputs, making it easier when combining it with other modules. Also, cleaned up the module and added a -stub-run test case.

arnaudbore
arnaudbore previously approved these changes Nov 29, 2024
Copy link
Contributor

@arnaudbore arnaudbore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG

Copy link
Contributor

@ThoumyreStanislas ThoumyreStanislas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just changes the meta.yml to match the new inputs

Copy link
Contributor

@ThoumyreStanislas ThoumyreStanislas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything looks good

@arnaudbore arnaudbore added this pull request to the merge queue Nov 29, 2024
Merged via the queue into scilus:main with commit c954f4f Nov 29, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants