Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Update registration modules #23

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

gagnonanthony
Copy link
Contributor

Type of improvement

  • Documentation
  • Development tools (e.g. linter, formatter, etc.)
  • Development container
  • Global update (please specify)
  • Other (please specify)

Describe your improvement

Update registration modules with Alex's changes. #14

Also made several changes to the test data used to make the test runs faster.

Checklist before requesting a review

  • Ensure the syntax is correct (EditorConfig and Prettier must pass)
  • Run the test suites if your changes affect any module
  • Regenerate the Poetry lock file if you have updated the dependencies
  • Ensure the documentation is up-to-date

@gagnonanthony gagnonanthony added the enhancement New feature or request label Oct 25, 2024
@gagnonanthony gagnonanthony self-assigned this Oct 25, 2024
Copy link
Contributor

@arnaudbore arnaudbore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG

@arnaudbore arnaudbore added this pull request to the merge queue Oct 30, 2024
Merged via the queue into scilus:main with commit d4ec0e6 Oct 30, 2024
22 checks passed
@gagnonanthony gagnonanthony deleted the update_registration branch October 30, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants