Add RAM Estimation Feature for Ripser Parameters Calculation (Fixes #145) #185
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Title: Add Memory Estimation Functionality to Ripser
Related Issue: #145 - Knowing required RAM to run ripser
Background:
This pull request addresses the concerns raised in issue #145, where users experience out-of-memory errors when running Ripser due to varying parameters such as the number of points, the number of features, and the maximum dimension value. To mitigate this issue, we introduce a new functionality to estimate the RAM requirements prior to executing Ripser.
Summary of Changes Implemented:
New Memory Estimation Function:
estimate_ripser_memory
which allows users to estimate the RAM requirements based on key parameters:Testing:
test/test_memory_estimation.py
to ensure:Documentation Updates:
__all__
list in the module to include the new memory estimation function.README.md
, showcasing how to utilize theestimate_ripser_memory
function to assess memory requirements.Usage Example:
Users can estimate the RAM needed for their runs of Ripser using the following code snippet:
These enhancements will help users to preemptively gauge the memory needs for their computations, reducing the likelihood of experiencing out-of-memory errors during execution.
Conclusion:
This pull request aims to improve the user experience by providing a reliable method for estimating RAM usage, thus addressing the issue raised in #145 effectively.
Fixes #145.