Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPD: Refactorisation of MapieClassifier #376

Closed
candicemyt opened this issue Nov 13, 2023 · 2 comments
Closed

UPD: Refactorisation of MapieClassifier #376

candicemyt opened this issue Nov 13, 2023 · 2 comments
Assignees
@candicemyt
Labels
Discussion in progress Discussion ongoing between the Mapie team and the author. Enhancement Type: enhancement (new feature or request) Other or internal If no other grey tag is relevant or if issue from the MAPIE team Source: developers Proposed by developers.
Milestone
0.9.0

Comments

@candicemyt
Copy link
Collaborator

candicemyt commented Nov 13, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.
The MapieClassifier class needs to be aligned with the MapieRegressor.

Describe the solution you'd like
The computation of the conformity scores (currently called method) should be done in a separate class as well as the handling of the base predictor.
@candicemyt candicemyt added the Enhancement Type: enhancement (new feature or request) label Nov 13, 2023
@candicemyt candicemyt self-assigned this Nov 13, 2023
@candicemyt candicemyt added the Source: developers Proposed by developers. label Nov 13, 2023
@LacombeLouis LacombeLouis added this to the 0.9.0 milestone Apr 25, 2024
@github-actions github-actions bot mentioned this issue Jun 24, 2024
Open
@jawadhussein462 jawadhussein462 added Discussion in progress Discussion ongoing between the Mapie team and the author. Classification Related to classification labels Nov 7, 2024
@Valentin-Laurent Valentin-Laurent added Other or internal If no other grey tag is relevant or if issue from the MAPIE team and removed Classification Related to classification labels Dec 20, 2024
@Valentin-Laurent
Copy link
Collaborator

Valentin-Laurent commented Dec 20, 2024 •
edited
Loading

Hello @candicemyt @LacombeLouis
This issue is quite old, is this still relevant?

@candicemyt
Copy link
Collaborator Author

Hello @Valentin-Laurent, this has been resolved by #476

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@candicemyt candicemyt

Labels
Discussion in progress Discussion ongoing between the Mapie team and the author. Enhancement Type: enhancement (new feature or request) Other or internal If no other grey tag is relevant or if issue from the MAPIE team Source: developers Proposed by developers.
Projects
None yet
Milestone
0.9.0
Development

When branches are created from issues, their pull requests are automatically linked.

376-refacto-mapieclassifier scikit-learn-contrib/MAPIE
4 participants
@Valentin-Laurent @jawadhussein462 @candicemyt @LacombeLouis