You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Based off of the experience of Issue #2353, I was curious how much work it would take to add testing for Windows. The answer seems to be not much for Python 3.9+. For Python 3.8 this fails as there is no jaxlib for Python 3.8, but all the backends for Python 3.9+ support Windows wheels.
There's an additional caveat that many tests in tests/test_scripts.py currently fail on Windows, and so the passing screen shot runs with --ignore tests/test_scripts.py, but all the Python tests pass.
I don't think that we should add the testing to the normal CI that runs on every PR as this would slow things down a bit, so I would propose using
on:
# Run daily at 1:23 UTCschedule:
- cron: '23 1 * * *'workflow_dispatch:
to have the Windows tests run as a nightly CRON job and then on deman with workflow dispatch (which is what I have in the passing tests above).
Based off of the experience of Issue #2353, I was curious how much work it would take to add testing for Windows. The answer seems to be not much for Python 3.9+. For Python 3.8 this fails as there is no
jaxlib
for Python 3.8, but all the backends for Python 3.9+ support Windows wheels.There's an additional caveat that many tests in
tests/test_scripts.py
currently fail on Windows, and so the passing screen shot runs with--ignore tests/test_scripts.py
, but all the Python tests pass.I don't think that we should add the testing to the normal CI that runs on every PR as this would slow things down a bit, so I would propose using
to have the Windows tests run as a nightly CRON job and then on deman with workflow dispatch (which is what I have in the passing tests above).
@kratsg @lukasheinrich what are your thoughts?
The text was updated successfully, but these errors were encountered: