Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic testing for Windows #2358

Closed
matthewfeickert opened this issue Oct 25, 2023 · 0 comments · Fixed by #2363
Closed

Add basic testing for Windows #2358

matthewfeickert opened this issue Oct 25, 2023 · 0 comments · Fixed by #2363
Assignees
Labels
CI CI systems, GitHub Actions Windows Issue related to Microsoft Windows

Comments

@matthewfeickert
Copy link
Member

Based off of the experience of Issue #2353, I was curious how much work it would take to add testing for Windows. The answer seems to be not much for Python 3.9+. For Python 3.8 this fails as there is no jaxlib for Python 3.8, but all the backends for Python 3.9+ support Windows wheels.

image

There's an additional caveat that many tests in tests/test_scripts.py currently fail on Windows, and so the passing screen shot runs with --ignore tests/test_scripts.py, but all the Python tests pass.

I don't think that we should add the testing to the normal CI that runs on every PR as this would slow things down a bit, so I would propose using

on:
  # Run daily at 1:23 UTC
  schedule:
  - cron:  '23 1 * * *'
  workflow_dispatch:

to have the Windows tests run as a nightly CRON job and then on deman with workflow dispatch (which is what I have in the passing tests above).

@kratsg @lukasheinrich what are your thoughts?

@matthewfeickert matthewfeickert added the CI CI systems, GitHub Actions label Oct 25, 2023
@matthewfeickert matthewfeickert self-assigned this Oct 25, 2023
@matthewfeickert matthewfeickert added the Windows Issue related to Microsoft Windows label Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI systems, GitHub Actions Windows Issue related to Microsoft Windows
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant