Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: some minor updates #1051

Merged
merged 1 commit into from
Oct 10, 2024
Merged

chore: some minor updates #1051

merged 1 commit into from
Oct 10, 2024

Conversation

henryiii
Copy link
Member

@henryiii henryiii commented Oct 9, 2024

A few things I noticed that can be updated. Modern version of ruff can auto-detect src layout. scikit-build-core 0.10+ can read the min version from the build-system.requires table.

@HDembinski HDembinski merged commit 8202577 into develop Oct 10, 2024
9 checks passed
@HDembinski HDembinski deleted the henryiii-patch-2 branch October 10, 2024 08:37
@HDembinski
Copy link
Member

Thanks. Btw, I am working on a patch to get pyhepmc up and running so that we can add a cp313 wheel there as well. I guess it is the last one missing for the scikit-hep package?

@henryiii
Copy link
Member Author

I don't think it's in the scikit-hep metapackage.

@HDembinski
Copy link
Member

Why not?

@henryiii
Copy link
Member Author

No idea. I think the goal is to have a somewhat basic subset of packages that tend to be used together. If it fits that, then it could be added. The larger gets, the more unwieldy it gets with potential version incompatibilities, so it should only be added if it’s something that people will generally want to have available with a basic install.

I wonder if we should start defining related subsets of packages as extras…

@HDembinski
Copy link
Member

Putting it in "extra" oder "all" makes sense. It is an important package, though, HEPMC3 format is a standard serialization format for event generators.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants