Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Linked items" in modal box do nothing (Ubuntu 16.04, v. 1.0.3) #101

Closed
pvanheus opened this issue Jun 28, 2017 · 3 comments
Closed

"Linked items" in modal box do nothing (Ubuntu 16.04, v. 1.0.3) #101

pvanheus opened this issue Jun 28, 2017 · 3 comments
Labels
Milestone

Comments

@pvanheus
Copy link

pvanheus commented Jun 28, 2017

Clicking "sciencefair" in the top right corner opens a model window:

image

There are three items - code, website and chat that appear to be links. Clicking on them does nothing.

@blahah blahah added the bug label Jun 28, 2017
@blahah blahah added this to the v1.1 milestone Jun 28, 2017
@blahah
Copy link
Member

blahah commented Jun 29, 2017

Hmm, these are just buttons with

btn.onclick = e => {
  e.preventDefault()
  opn(btnurl)
}

This works on OSX and Windows.

@sindresorhus any ideas why this would die without error on Ubuntu?

@sindresorhus
Copy link

Don't use opn with Electron. Electron has its own method for this: https://electron.atom.io/docs/api/shell/#shellopenitemfullpath

@blahah
Copy link
Member

blahah commented Jun 29, 2017

Ah, thanks @sindresorhus - actually you mentioned this before but I moved to opn rather than the electron native interface by accident. Sorry for troubling you again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants