Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerization #10

Closed
dmuth opened this issue Jul 14, 2019 · 5 comments
Closed

Dockerization #10

dmuth opened this issue Jul 14, 2019 · 5 comments

Comments

@dmuth
Copy link
Contributor

dmuth commented Jul 14, 2019

I'd like to propose a Dockerized version of hostyoself so that the CLI version can be run via a docker run command.

I'll be happy to contribute a Dockerfile and push the Docker image to Docker Hub. Just say the word! :-)

@schollz
Copy link
Owner

schollz commented Jul 14, 2019

It was too easy, so I pushed it! Thanks though!

@dmuth
Copy link
Contributor Author

dmuth commented Jul 14, 2019

FYI, the image doesn't seem to be uploaded to Docker Hub...?

$ docker pull schollz/hostyoself                                                                                                                                                     
Using default tag: latest
Error response from daemon: manifest for schollz/hostyoself:latest not found

@schollz
Copy link
Owner

schollz commented Jul 14, 2019

Yeah, I forgot to use go generate, try now!

@dmuth
Copy link
Contributor Author

dmuth commented Jul 15, 2019

Looks good! I actually was planning on running hostyoself in relay mode on one of my severs, and since your build runs host by default, I ended up expanding on it in my fork. I also fixed an issue with COPY . . which would cause the entire app to be recompiled if anything at all changed, such as the Dockerfile itself, or a Vim .swp file.

I'm going to send a PR shortly with what I did, but think of it less as a PR and more as a "pull this if you like". If you would prefer to pick and choose from what I did in my commit and integrate it by hand, feel free to do so, and treat it was a contribution under the existing license for this app. :-)

-- Doug

@schollz
Copy link
Owner

schollz commented Jul 15, 2019

Thanks Doug, that's awesome. I appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants