Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zstd as a compression algorithm. #504

Closed
stefins opened this issue Sep 5, 2022 · 5 comments
Closed

Add zstd as a compression algorithm. #504

stefins opened this issue Sep 5, 2022 · 5 comments

Comments

@stefins
Copy link
Contributor

stefins commented Sep 5, 2022

Is your feature request related to a problem? Please describe.
It would be better to add zstd as a compression algorithm for transferring file as it provides high compression ratio.

Describe the solution you'd like
We can use the go library https://github.com/DataDog/zstd for it.

Additional context
https://facebook.github.io/zstd/

@schollz
Copy link
Owner

schollz commented Sep 5, 2022

Would accept a PR for this

@stefins
Copy link
Contributor Author

stefins commented Sep 16, 2022

Closed in #506

@stefins stefins closed this as completed Sep 16, 2022
@schollz schollz reopened this Sep 16, 2022
@schollz
Copy link
Owner

schollz commented Sep 16, 2022

@stefins sorry - I reverted this change because unfortunately there is no scheme in place to have different compression algorithms so this would be a breaking change. I'm okay with a breaking change, but I'll wait a bit before releasing it, possibly with another breaking change.

Lets keep this open until then!

@stefins
Copy link
Contributor Author

stefins commented Sep 16, 2022

Sure! No problem :)

Copy link

Stale issue message

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants