Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dragging with touch also scrolls the page, making it impossible to drag accurately #35

Open
WestonThayer opened this issue Feb 12, 2019 · 3 comments
Open

Dragging with touch also scrolls the page, making it impossible to drag accurately #35

WestonThayer opened this issue Feb 12, 2019 · 3 comments

Comments

@WestonThayer
Copy link

untitled

  1. On a touch device, touch down on a draggable item on the demo page
  2. Drag your finger up or down

Actual: page is scrolled
Expected: page remains fixed, only item moves

Adding overflow-y: hidden while dragging to <body> will fix this, but stopping event bubbling might be a better fix.
@WestonThayer
Copy link
Author

Ah, looks like dragula also has this issue, assuming that's the root cause.

@WestonThayer
Copy link
Author

bevacqua/dragula#426

@WestonThayer
Copy link
Author

Adding some UX notes. On iOS:

  • For list items with a drag handle, the item is grabbed immediately upon touchstart of the handle
  • For list items without a drag handle, there's ~1s press-and-hold delay before the item is grabbed (otherwise it would be difficult to scroll the page)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@WestonThayer