Use PsrCachedReader and drop doctrine/cache #1327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
simPod
commented
Jun 25, 2021
simPod
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| Doc updated | no |
| BC breaks? | yes |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #... |
| License | MIT |
simPod
force-pushed
the
psr-cache
branch
2 times, most recently
from
d3f78c4
to
94c5b62
Compare
Merged
goetas
reviewed
Jun 29, 2021
| @@ -525,8 +525,8 @@ public function build(): Serializer | |||
|
|
|||
| if (null !== $this->cacheDir) { | |||
| $this->createDir($this->cacheDir . '/annotations'); | |||
| $annotationsCache = new FilesystemCache($this->cacheDir . '/annotations'); | |||
| $annotationReader = new CachedReader($annotationReader, $annotationsCache, $this->debug); | |||
| $annotationsCache = new FilesystemAdapter('', 0, $this->cacheDir . '/annotations'); | |||
There was a problem hiding this comment.
this would result in a breaking change for people who have not yet installed the symfony/cache component.
I would suggest to check it the Symfony\Component\Cache\Adapter\FilesystemAdapter class exists use that, if not fallback to the current caching classes.
|
What's the status on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.