Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for iterable and Iterator #1096

Merged
merged 1 commit into from
Jun 15, 2019
Merged

Add support for iterable and Iterator #1096

merged 1 commit into from
Jun 15, 2019

Conversation

simPod
Copy link
Contributor

@simPod simPod commented Jun 14, 2019 •
edited
Loading

Q A
Bug fix? no
New feature? yes
Doc updated yes
BC breaks? no
Deprecations? no
Tests pass? no
Fixed tickets #1094
License MIT
  • Add iterable support
  • Add Iterator support
  • Make iterable work with jms/meta

@simPod
Copy link
Contributor Author

simPod commented Jun 14, 2019

@goetas jms/meta heavily relies on ReflectionClass. However, it's not possible to create reflection class from iterable. Any idea how to tackle it?

goetas
goetas reviewed Jun 14, 2019
View reviewed changes
Copy link
Collaborator

@goetas goetas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi!
Looks good so far! I have left only two comments!

composer.json Outdated Show resolved Hide resolved
src/Functions/iterable_to_array.php Outdated Show resolved Hide resolved
@goetas goetas self-requested a review June 14, 2019 05:42
@goetas
Copy link
Collaborator

goetas commented Jun 14, 2019 •
edited
Loading

@goetas jms/meta heavily relies on ReflectionClass. However, it's not possible to create reflection class from iterable. Any idea how to tackle it?

Can you explain which problems gives this?

Have you tried placing iterable here ?

@simPod
Copy link
Contributor Author

simPod commented Jun 14, 2019

@goetas ooooooh 👍

@simPod simPod changed the title WIP: Add support for iterable and Iterator Add support for iterable and Iterator Jun 14, 2019
@goetas goetas merged commit 0b50588 into schmittjoh:master Jun 15, 2019
@goetas
Copy link
Collaborator

goetas commented Jun 15, 2019

Thanks a lot!

@goetas
Copy link
Collaborator

goetas commented Jun 15, 2019

Well done!

@simPod simPod deleted the iterable branch June 15, 2019 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goetas goetas Awaiting requested review from goetas

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simPod @goetas