Make possible to set ArrayCollectionHandler classes from outside

[alexander-schranz]

Q	A
Bug report?	no
Feature request?	yes
BC Break report?	no
RFC?	yes/no?

The ArrayCollectionHandler classes are currently hardcoded. It would be good if the ArrayCollectionHandler get its classes from outside and so in the jms serializer bundle I could use PrependExtension in my bundle config to add a class to the ArrayCollectionHandler.

Expected Result

• Allow to add ArrayCollection classes to Handler

Actual Result

• Classes are hardcoded and no other classes can be added from outside.

[goetas]

What do you mean by "hardcoded" ?

If you want to add extra extensions you can do this:

$serializerBuilder = SerializerBuilder::create();
$serializerBuilder->addMetadataDir('metadata dir', 'TestNs');
$serializerBuilder->configureHandlers(function (HandlerRegistryInterface $handler) use ($serializerBuilder) {
     // default handlers
    $serializerBuilder->addDefaultHandlers();
   // your handlers
   $handler->registerSubscribingHandler(new YourhandlerHere());
});

[alexander-schranz]

@goetas sorry I mean this classes are hardcoded:

serializer/src/Handler/ArrayCollectionHandler.php

Lines 34 to 40 in 4c1e429

	$collectionTypes = [
	'ArrayCollection',
	'Doctrine\Common\Collections\ArrayCollection',
	'Doctrine\ORM\PersistentCollection',
	'Doctrine\ODM\MongoDB\PersistentCollection',
	'Doctrine\ODM\PHPCR\PersistentCollection',
	];

And would think about something like this in the JMS SerializerBundle to add your custom ArrayCollectionClasses:

jms_serializer:
     handlers:
          array_collection:
                classes:
                      - CustomClass

[goetas]

you can easily register more handlers

<service id="app.my_handler" class="JMS\Serializer\Handler\ArrayCollectionHandler">
    <tag name="jms_serializer.handler" type="CustomClass" 
                direction="serialization" format="json"
                method="serializeCollection" />

    <tag name="jms_serializer.handler" type="CustomClass"
                direction="deserialization" format="json"
                method="deserializeCollection" />
</service>

This will register ArrayCollectionHandler for the CustomClass type

[alexander-schranz]

Oh didn't thought about that solution. Great! Thank you!