Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] revert #946 and release new major #1058

Closed
goetas opened this issue Mar 4, 2019 · 0 comments · Fixed by #1071
Closed

[RFC] revert #946 and release new major #1058

goetas opened this issue Mar 4, 2019 · 0 comments · Fixed by #1071
Labels
RFC

Comments

@goetas
Copy link
Collaborator

goetas commented Mar 4, 2019

Q A
Bug report? yes/no
Feature request? yes/no
BC Break report? yes/no
RFC? yes/no

I'm starting to think about releasing jms/serializer v3 just to be able to revert #946

At that time the change made sense to me (and code got simpler too), but I started recently to migrate some bigger projects and this change made more damage than good.
Thus I'm thinking about a new major just to revert this.

What do you think?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
RFC
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert v2 nested groups and release 3.0 schmittjoh/serializer
1 participant
@goetas